Khaganat-NeL/khanat-opennel-code
2
0
Fork 0
Code Issues 21 Pull requests Projects Releases 1 Packages Wiki Activity

Don't create transactions for SELECT queries

Browse source
This commit is contained in:
kaetemi 2014-09-03 05:39:16 +02:00
parent 33d7bf5c15
commit 3f9eb61e07
1 changed files with 32 additions and 43 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

75
code/web/private_php/ams/autoload/dblayer.php
View file

@ -135,13 +135,12 @@ class DBLayer {
$sth -> execute(); $sth -> execute();
$lastId = $this -> PDO -> lastInsertId(); $lastId = $this -> PDO -> lastInsertId();
$this -> PDO -> commit(); $this -> PDO -> commit();
} }
catch ( Exception $e ) catch ( Exception $e ) {
{
// for rolling back the changes during transaction // for rolling back the changes during transaction
$this -> PDO -> rollBack(); // $this -> PDO -> rollBack();
throw new Exception( "error in inseting" ); throw $e; // new Exception( "error in inseting" );
} }
return $lastId; return $lastId;
} }
@ -158,14 +157,11 @@ class DBLayer {
public function selectWithParameter( $param, $tb_name, $data, $where ) { public function selectWithParameter( $param, $tb_name, $data, $where ) {
$this->useDb(); $this->useDb();
try { try {
$sth = $this -> PDO -> prepare( "SELECT $param FROM $tb_name WHERE $where" ); $sth = $this->PDO->prepare( "SELECT $param FROM $tb_name WHERE $where" );
$this -> PDO -> beginTransaction(); $sth->execute( $data );
$sth -> execute( $data );
$this -> PDO -> commit();
} }
catch ( Exception $e ) { catch ( Exception $e ) {
$this -> PDO -> rollBack(); throw $e; // new Exception( "error selection" );
throw new Exception( "error selection" );
return false; return false;
} }
return $sth; return $sth;
@ -180,22 +176,18 @@ class DBLayer {
* @param string $where where to select in format('fieldname=:fieldname' AND ...). * @param string $where where to select in format('fieldname=:fieldname' AND ...).
* @return statement object. * @return statement object.
*/ */
public function select( $tb_name, $data , $where ) { public function select($tb_name, $data , $where) {
$this->useDb(); $this->useDb();
try { try {
$sth = $this -> PDO -> prepare( "SELECT * FROM $tb_name WHERE $where" ); $sth = $this->PDO->prepare("SELECT * FROM $tb_name WHERE $where");
$this -> PDO -> beginTransaction(); $sth->execute( $data );
$sth -> execute( $data );
$this -> PDO -> commit();
}
catch( Exception $e )
{
$this -> PDO -> rollBack();
throw new Exception( "error selection" );
return false;
}
return $sth;
} }
catch (Exception $e) {
throw $e; // new Exception( "error selection" );
return false;
}
return $sth;
}
/** /**
* Update function with prepared statement. * Update function with prepared statement.
@ -208,30 +200,27 @@ class DBLayer {
public function update( $tb_name, $data, $where ) { public function update( $tb_name, $data, $where ) {
$this->useDb(); $this->useDb();
$field_option_values = null; $field_option_values = null;
foreach ( $data as $key => $value ) foreach ( $data as $key => $value ) {
{
$field_option_values .= ",$key" . '=:' . $key; $field_option_values .= ",$key" . '=:' . $key;
} }
$field_option_values = ltrim( $field_option_values, ',' ); $field_option_values = ltrim( $field_option_values, ',' );
try { try {
$sth = $this -> PDO -> prepare( "UPDATE $tb_name SET $field_option_values WHERE $where " ); $sth = $this -> PDO -> prepare( "UPDATE $tb_name SET $field_option_values WHERE $where " );
foreach ( $data as $key => $value ) foreach ( $data as $key => $value ) {
{
$sth -> bindValue( ":$key", $value ); $sth -> bindValue( ":$key", $value );
} }
$this -> PDO -> beginTransaction(); $this -> PDO -> beginTransaction();
$sth -> execute(); $sth -> execute();
$this -> PDO -> commit(); $this -> PDO -> commit();
} }
catch ( Exception $e ) catch ( Exception $e ) {
{ $this->PDO->rollBack();
$this -> PDO -> rollBack(); throw $e; // new Exception( 'error in updating' );
throw new Exception( 'error in updating' );
return false; return false;
}
return true;
} }
return true;
}
/** /**
* insert function using prepared statements. * insert function using prepared statements.
@ -272,14 +261,14 @@ class DBLayer {
public function delete( $tb_name, $data, $where ) { public function delete( $tb_name, $data, $where ) {
$this->useDb(); $this->useDb();
try { try {
$sth = $this -> PDO -> prepare( "DELETE FROM $tb_name WHERE $where" ); $sth = $this->PDO->prepare( "DELETE FROM $tb_name WHERE $where" );
$this -> PDO -> beginTransaction(); $this->PDO->beginTransaction();
$sth -> execute( $data ); $sth->execute( $data );
$this -> PDO -> commit(); $this->PDO->commit();
} }
catch (Exception $e) { catch (Exception $e) {
$this -> PDO -> rollBack(); $this->PDO->rollBack();
throw new Exception( "error in deleting" ); throw $e; // new Exception( "error in deleting" );
} }
} }
} }